New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt baseline to Pharo 7. #979
Conversation
Close issue #978 |
I merged the PR#980 for dev branch, but it shows we hit another issue in Metacello/metacello#476 |
I just tried to load Seaside 3.2 (GitHub.1516790362) in Pharo 7 (Pharo-7.0+alpha.build.493.sha.d53a70bc946ed83b046f61ac35f00c67fa77269a (32 Bit)) with the changes proposed here and at least the load and some quick testing with ZnZincSeasideAdaptor seems to indicate no direct problems. Why don't we integrate this so that others can load Seaside 3.2 in Pharo 7 too ? This is really important to make progress, IMHO. |
I can try again but we did hit issues: https://travis-ci.org/SeasideSt/Seaside/jobs/313946580 |
With the modifications described here (just add a couple of #'pharo7.x' tags here and there) the load worked. I did see the same error first, but not with the modified baseline loaded. I did do this load interactively, not as a CI build, using:
|
I'll take another look but Seaside builds on SmalltalkCI are failing for Pharo 7, so as long as this is the case, we cannot reliably move to Pharo7. Now, I understand we should at least make it load and I will merge now. |
Copied the changes of this PR in 3c7efa6 |
@jbrichau There was more changes than this. |
There was also: baselinejavascript..st, baselinerest..st and baselineslime..st |
@jecisc Yeah, noticed it too. Thanks for watching. I added another commit. |
No description provided.