Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt baseline to Pharo 7. #979

Closed
wants to merge 1 commit into from

Conversation

jecisc
Copy link
Member

@jecisc jecisc commented Dec 2, 2017

No description provided.

@jecisc
Copy link
Member Author

jecisc commented Dec 2, 2017

Close issue #978

@jecisc jecisc mentioned this pull request Dec 2, 2017
@jbrichau
Copy link
Member

jbrichau commented Dec 9, 2017

I merged the PR#980 for dev branch, but it shows we hit another issue in Metacello/metacello#476
Holding off merging this for master when that's fixed

@svenvc
Copy link

svenvc commented Feb 7, 2018

I just tried to load Seaside 3.2 (GitHub.1516790362) in Pharo 7 (Pharo-7.0+alpha.build.493.sha.d53a70bc946ed83b046f61ac35f00c67fa77269a (32 Bit)) with the changes proposed here and at least the load and some quick testing with ZnZincSeasideAdaptor seems to indicate no direct problems.

Why don't we integrate this so that others can load Seaside 3.2 in Pharo 7 too ?

This is really important to make progress, IMHO.

@jbrichau
Copy link
Member

jbrichau commented Feb 7, 2018

I can try again but we did hit issues: https://travis-ci.org/SeasideSt/Seaside/jobs/313946580
So, the load now works?

@svenvc
Copy link

svenvc commented Feb 7, 2018

With the modifications described here (just add a couple of #'pharo7.x' tags here and there) the load worked. I did see the same error first, but not with the modified baseline loaded. I did do this load interactively, not as a CI build, using:

Metacello new
 baseline:'Seaside3';
 repository: 'github://SeasideSt/Seaside:master/repository';
 load.

@jbrichau
Copy link
Member

jbrichau commented Feb 7, 2018

I'll take another look but Seaside builds on SmalltalkCI are failing for Pharo 7, so as long as this is the case, we cannot reliably move to Pharo7. Now, I understand we should at least make it load and I will merge now.

jbrichau added a commit that referenced this pull request Feb 7, 2018
@jbrichau
Copy link
Member

jbrichau commented Feb 7, 2018

Copied the changes of this PR in 3c7efa6

@jecisc
Copy link
Member Author

jecisc commented Feb 7, 2018

@jbrichau There was more changes than this.

@jecisc
Copy link
Member Author

jecisc commented Feb 7, 2018

There was also: baselinejavascript..st, baselinerest..st and baselineslime..st

jbrichau added a commit that referenced this pull request Feb 7, 2018
@jbrichau
Copy link
Member

jbrichau commented Feb 7, 2018

@jecisc Yeah, noticed it too. Thanks for watching. I added another commit.
Mind that the load: 'CI' does not work because of a DNU on Pragma, so this needs to change as well if we want a build.

@jbrichau jbrichau closed this Feb 7, 2018
@jecisc jecisc deleted the cf_adapt_baseline_to_pharo7 branch December 26, 2018 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants